Repository navigation
feat(webapp): make IAM-mode object store path style configurable (PLT-1715) - #29
Open
jmho-govsignals wants to merge 1 commit into
Open
jmho-govsignals wants to merge 1 commit into
jmho-govsignals wants to merge 1 commit into
Conversation
…-1715) The AWS SDK object store client hardcoded forcePathStyle: true. AWS FIPS endpoints (s3-fips.<region>.amazonaws.com), which FedStart requires, only accept virtual-hosted-style requests, so IAM-mode packet uploads and presigned URLs could not work there. Add OBJECT_STORE_FORCE_PATH_STYLE (and OBJECT_STORE_<PROTOCOL>_FORCE_PATH_STYLE for named providers), defaulting to true so existing installs keep path-style addressing. Only the IAM-mode client reads it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jmho-govsignals
marked this pull request as ready for review
November 18, 2026 21:38
arkwinta
approved these changes
Nov 18, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
After this merges, an operator can switch the webapp's IAM-mode object store (no access keys, AWS credential chain) from path-style to virtual-hosted-style S3 addressing with one env var. FedStart needs this: Mission Manager only allows the FIPS endpoint
s3-fips.us-gov-west-1.amazonaws.com, and that endpoint only works with virtual-hosted-style URLs (<bucket>.s3-fips.…/<key>). The IAM-mode client hardcodedforcePathStyle: true, so no configuration could produce a URL FedStart accepts. Task payloads and outputs over 128 KB, which go throughPUT /api/v2/packets/*, fail there today.With the default (
true), every existing install keeps path-style addressing, IL5 included.Changes
ObjectStoreClientConfig.forcePathStyleapps/webapp/app/v3/objectStoreClient.server.tsChanged:
AwsSdkClientnow takesforcePathStylefrom its config, andObjectStoreClient.createpassesconfig.forcePathStyle ?? true. The static-credentialAws4FetchClientpath is unchanged.OBJECT_STORE_FORCE_PATH_STYLE,OBJECT_STORE_<PROTOCOL>_FORCE_PATH_STYLEapps/webapp/app/env.server.ts,apps/webapp/app/v3/objectStore.server.ts,docs/self-hosting/env/webapp.mdxChanged: a
BoolEnvsetting, defaulttrue, read for the default provider and for each named provider, and documented in the self-hosting env table. Only the IAM-mode client uses it.Proves (tests in
test/objectStoreClient.test.ts, no containers: presigning is local SigV4 signing with stubbed env credentials):s3-fips…/<bucket>/<key>)forcePathStyle: false, PUT and GET presigns are virtual-hosted (<bucket>.s3-fips…/<key>) and useAWS4-HMAC-SHA256Checked by breaking it: with
forcePathStyle: truehardcoded again, 2 of the 3 tests fail.Not in this PR
webapp.extraEnvVars.ArtifactsServicebuilds its ownS3Client. It already uses virtual-hosted addressing in IAM mode and FedStart doesn't use it, so it is untouched.Validation
vitest run test/objectStoreClient.test.ts: 3 passed.oxfmt --checkon the changed files: clean.tscon the client and the new test in isolation: no errors. The fullapps/webapptypecheck could not run cleanly locally because workspace packages (@trigger.dev/core,@trigger.dev/database) were not built. All ~1,900 errors were "cannot find module" for those packages, not from this change.test/objectStore.test.ts.trigger-aws-role) will confirm it before this merges.Ticket: PLT-1715
🤖 Generated with Claude Code